@mrsimpson, can you fix the conflicts in this PR, please?
Thx.

@renatobecker of course. Before I do, please let me know if it’s ok to have livechat specific code in these files

@mrsimpson, You will see that there have been many changes in the packages/rocketchat-lib/server/lib/sendNotificationsOnMessage.js file since your implementation.
I suggest you to move your code to rocketchat-livechat package because it's a specific approach to that feature.

Thanks.

@renatobecker

You will see that there have been many changes in the packages/rocketchat-lib/server/lib/sendNotificationsOnMessage.js file since your implementation.

I had already fixed this, however I'm not too happy with the implementation (as said four days ago)

Still, I just updated this PR now to match the current development state. Because of the way notifications in RC are implemented, it's quite tricky to move the code to the livechat-package without duplicating a lot of code.

Please have a look at it whether it matches your architectural needs or if it really has to move. In the later case, I'd appreciate if someone from the core-team did the refactoring of the notifications-stuff into a library).

@mrsimpson, looking deeply your implementation, I can see that you are using an approach where the notifications will be triggered for every new messages that the guest/visitor sends, not just the first message when the inquiry is created, am I right?
If I'm not wrong, this behaviour is not the same as requested on the issue #11137, because there the user is asking for notifications just when the inquiry is created what, IMO, would be best for a standard implementation.

If I'm wrong about your use case, please let me know.

In addition: The migration of the code to rockechat-livechat package could be easy if the purpose of this approach is to notify agents for new incoming Livechats.

I'll be waiting for your feedback.
Thanks.

All committers have signed the CLA.

@renatobecker like this? Now, a new notification is being create only for the first message which creates the queue entry - fixes #11137